Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp-pistache-server]: Fix build with pistache master branch #10829

Merged
merged 4 commits into from
Nov 14, 2021

Conversation

sheabot
Copy link
Contributor

@sheabot sheabot commented Nov 10, 2021

CC: @ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328
Copy link
Member

wing328 commented Nov 11, 2021

@sheabot thanks for the PR. Is this a breaking change without fallback? Does the newly auto-generated C++ code support older version of C++?

@sheabot
Copy link
Contributor Author

sheabot commented Nov 12, 2021

Hi @wing328. Pistache upgraded to C++17 in pistacheio/pistache#859, which makes C++17 the minimum requirement to build against pistache. Since then, the auto-generated C++ code doesn't actually build against the pistache master branch.

So to answer your question, yes this is a breaking change and no older versions of C++ are not supported. This is necessary due to pistache's breaking changes. Without this, the auto-generated code will forever be pinned to an old version of pistache before these changes were merged.

@wing328
Copy link
Member

wing328 commented Nov 14, 2021

@sheabot thanks for the explanation. Let's move ahead with this change.

@wing328 wing328 merged commit f2fcff2 into OpenAPITools:master Nov 14, 2021
@sheabot sheabot deleted the bugfix/cpp-pistache-master branch November 15, 2021 16:08
@wing328 wing328 added this to the 5.3.1 milestone Dec 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [cpp-pistache-server] Generated cmake project does not build
3 participants