[csharp] Use the provided 'sourceFolder' property to generate the test folder #10738
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi all!
This issue is regarding the
csharp-netcore
generator. There is a bit of an inconsistency in how the test folders are generated when thesourceFolder
property is provided. For example:sourceFolder
to anything other thansrc
.--additional-properties=sourceFolder=""
sourceFolder
... but the tests where generated insrc
:In the
AbstractCSharpCodegen.java
, there is a TODO a few years old saying that a separate option fortestFolder
could be added:openapi-generator/modules/openapi-generator/src/main/java/org/openapitools/codegen/languages/AbstractCSharpCodegen.java
Lines 73 to 75 in 8551b0a
Until that is implemented, I created a little workaround, assigning the provided
sourceFolder
parameter to thetestFolder
.With this change, the projects are generated as expected:
![image](https://user-images.githubusercontent.com/16015792/139577691-7df23aa3-3804-4d2d-a1f1-b48ab209e204.png)
Related issue: #1390
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x