Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix alias to map response #1067

Merged
merged 3 commits into from
Sep 20, 2018
Merged

Fix alias to map response #1067

merged 3 commits into from
Sep 20, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Sep 19, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

To fix #398

cc @OpenAPITools/generator-core-team

@etherealjoy
Copy link
Contributor

etherealjoy commented Sep 20, 2018

@wing328
I tested this for go and cpp-qt5 and it seems to work.

Some deficiencies show up now in the language specific generator after the alias is resolved but it works.
We can improve the language specific generators after this is merged.

@wing328 wing328 added this to the 3.3.0 milestone Sep 20, 2018
@wing328 wing328 merged commit 1b2f3fb into master Sep 20, 2018
@wing328 wing328 deleted the fix_map_response branch September 20, 2018 11:29
jaumard pushed a commit to jaumard/openapi-generator that referenced this pull request Sep 21, 2018
* fix response reference to map

* update samples

* add null check for openapi
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* fix response reference to map

* update samples

* add null check for openapi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incomplete type when response body is a ref to a map
2 participants