Add post processing to files generated by TS generators #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macjohnny
reviewed
Sep 19, 2018
|
|
||
| @Override | ||
| public void postProcessFile(File file, String fileType) { | ||
| if (file == null) { |
There was a problem hiding this comment.
i suggest to call the parent method, too, since there could be some logic added later.
| /** | ||
| * Describes the result of uploading an image resource | ||
| */ | ||
| * Describes the result of uploading an image resource |
There was a problem hiding this comment.
why was this changed? the generation parameters of the typescript-node samples have not changed, so I guess this is because of a local test?
There was a problem hiding this comment.
I simply want to show the change made by prettier.
I'll restore the old one before merging.
|
If no further feedback or question, I'll merge it tomorrow (Saturday) |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
…#1063) * add file post proess to TS generators * update ts node petstore with prettier * update base on feedback
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.3.x,4.0.x. Default:master.Description of the PR
Allow users to define the environment variable "TS_POST_PROCESS_FILE" to post process TS files generated by TS generators (e.g. Angular, Fetch, etc), e.g.
export TS_POST_PROCESS_FILE='/usr/local/bin/prettier --write'Please refer to 07b2a36 for the code changes done by
prettieras an example.cc @TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @nicokoenig (2018/09)