Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file post processing to Ruby generators #1062

Merged
merged 3 commits into from
Sep 20, 2018
Merged

Add file post processing to Ruby generators #1062

merged 3 commits into from
Sep 20, 2018

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Sep 19, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Allow users to define the environment variable "RUBY_POST_PROCESS_FILE" to post process Ruby files generated by Ruby generators (e.g. Ruby client, Ruby on Rails, etc), e.g. export RUBY_POST_PROCESS_FILE=/usr/local/bin/rubocop -a

cc @cliffano (2017/07) @zlx (2017/09)

@wing328 wing328 added this to the 3.3.0 milestone Sep 19, 2018
@wing328 wing328 merged commit cc6efe0 into master Sep 20, 2018
@wing328 wing328 deleted the postProcessRuby branch September 20, 2018 11:31
jaumard pushed a commit to jaumard/openapi-generator that referenced this pull request Sep 21, 2018
* add post processing for Ruby file

* move ruby file post process to abstract ruby class

* remove line break
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* add post processing for Ruby file

* move ruby file post process to abstract ruby class

* remove line break
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant