-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Java][Feign] Add http status to feign result #10583
[Java][Feign] Add http status to feign result #10583
Conversation
…hugo-ma-alves/openapi-generator into feature/add-http-status-to-feign-result
|
||
public int getStatus(){ | ||
return status; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hugo-ma-alves can we make HttpResponse look more like ApiResponse ?
The goal is to make it consistent across different Java http library.
(in other words, I suggest we rename HttpResponse to ApiResponse)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the suggestion.
I refactored the templates to rename the HttpResponse to ApiResponse, and to keep it coherent I also renamed the JacksonResponseDecoder to ApiResponseDecoder.
Just had to update my branch with the latest master changes 🤷♂️ |
LGTM |
To improve the previous PR #10507.
This PR adds the Http status code to the feign response.
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x
@wing328
@bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)