Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add file post-processing support for Java generators #1052

Merged
merged 4 commits into from
Oct 23, 2018
Merged

Conversation

wing328
Copy link
Member

@wing328 wing328 commented Sep 18, 2018

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

Add post-processing Java files using the environment variable JAVA_POST_PROCESS_FILE

e.g. export JAVA_POST_PROCESS_FILE="/usr/local/bin/clang-format -i"

@wing328 wing328 changed the title [WIP] Add clang-format support for Java generators Add file post-processing support for Java generators Oct 10, 2018
@wing328 wing328 removed the WIP Work in Progress label Oct 10, 2018
@wing328 wing328 added this to the 3.3.1 milestone Oct 10, 2018
@wing328
Copy link
Member Author

wing328 commented Oct 10, 2018

cc @bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)

@wing328
Copy link
Member Author

wing328 commented Oct 15, 2018

UPDATE: added a global switch (default: false) via #1241

@wing328 wing328 modified the milestones: 3.3.1, 3.3.2 Oct 15, 2018
@wing328 wing328 merged commit 0001682 into master Oct 23, 2018
@wing328 wing328 deleted the java-code-format branch October 23, 2018 08:59
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
* add clang format support for java

* rename java env variable

* fix export command
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant