-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REQ] [RUBY] [FARADAY] Allow middleware to be configured #10495
[REQ] [RUBY] [FARADAY] Allow middleware to be configured #10495
Conversation
@johngallagher thanks for the PR, which looks good to me. Is there anything else you want to add to this PR? |
Wow - thanks @wing328 ! Ruby pom.xml tests are failing locally I was trying to get the Ruby pom.xml tests passing but couldn't figure out how to do that. UPDATE: Circle CI tests are failing Couldn't figure out how to fix that. I get a UPDATE: Bitrise CI tests are also failing
What do I do with the above failing tests? Ignore or should I try to fix? Docs needing updated? Are there any docs that need updating now that I've added some functionality to the Faraday client? |
Ruby tests passed via https://app.travis-ci.com/github/OpenAPITools/openapi-generator/builds/239029508 |
What and why
For more details, see this issue
Usage
More details
use
,request
andresponse
syntax to specify the different middlewarePR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*
.For Windows users, please run the script in Git BASH.
master
(5.3.0),6.0.x