[scala] Fix Array[Byte] type for Openapi type string format byte #10426
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is follow up #10166 PR to fix generation of
Array[Byte]type for the case:Ref https://swagger.io/docs/specification/data-models/data-types/
The root of cause is defined default as primitive type ByteArray with type mapping from
ByteArraytoArray[Byte]will be obfuscated toArray[Byte]whentoModelNameapplied.Proposed solution: do not apply
toModelNamefor explicit language mappings.Other possible solutions:
Array[Byte]ongetTypeDeclaration. Has disadvantage as string/byte openapi type is notArraySchemaand wrapper type need to be calculated within internal type. As on lower level that conversion already leads toByteArraywhich can be solved with more flexible explicit typeMapping that solution looks not clean.Related to: 75c0180#diff-15459547d6435da71e0b630591c8e81793affb8c8152b51fbb014b3e2bec4a55R98
PR checklist
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.For Windows users, please run the script in Git BASH.
master(5.3.0),6.0.x@clasnake (2017/07), @jimschubert (2017/09) ❤️, @shijinkui (2018/01), @ramzimaalej (2018/03), @chameleon82 (2020/03), @Bouillie (2020/04)