Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[haskell-http-client] add ability to choose additional characters in querystring which should not be encoded (e.g. "+" or ":") #10424

Merged
merged 1 commit into from
Sep 19, 2021

Conversation

jonschoning
Copy link
Contributor

@jonschoning jonschoning commented Sep 19, 2021

To fix #3459

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master (5.3.0), 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@jonschoning jonschoning force-pushed the haskell-http-client branch 2 times, most recently from 63d6685 to 47e8827 Compare September 19, 2021 03:34
@jonschoning
Copy link
Contributor Author

c.f. #3459

…querystring which should not be encoded (e.g. "+" or ":") (fixes #3459)
@jonschoning jonschoning merged commit 1247e77 into master Sep 19, 2021
@jonschoning jonschoning deleted the haskell-http-client branch September 19, 2021 17:39
@wing328 wing328 added this to the 5.3.0 milestone Oct 23, 2021
@wing328 wing328 changed the title [haskell-http-client] add ability to choose additional characters in querystring which should not be encoded (e.g. "+" or ":") (fixes #3459) [haskell-http-client] add ability to choose additional characters in querystring which should not be encoded (e.g. "+" or ":") Oct 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [haskell-http-client] Incorrectly generated query strings
2 participants