Add option to enable scalafmt for code formatting #1032
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramzimaalej
reviewed
Sep 14, 2018
| @@ -113,6 +114,10 @@ public AbstractScalaCodegen() { | |||
| public void processOpts() { | |||
| super.processOpts(); | |||
|
|
|||
| if (StringUtils.isEmpty(System.getenv("SCALAFMT_PATH"))) { | |||
| LOGGER.info("Environment variable SCALAFMT_PATH not defined so the Haskell code may not be properly formatted. To define it, try 'export SCALAFMT_PATH=/usr/local/bin/scalafmt' (Linux/Mac)"); | |||
There was a problem hiding this comment.
the Haskell code do you mean the Scala code?
There was a problem hiding this comment.
Fixed. Sorry for the copy & paste issue.
I did a search and confirmed there's no reference to Haskell.
ramzimaalej
approved these changes
Sep 14, 2018
|
@ramzimaalej thanks for the review. I'll merge the PR after the CI tests pass. |
jaumard
pushed a commit
to jaumard/openapi-generator
that referenced
this pull request
Sep 21, 2018
* add option to enable scalafmt for code formatting * fix typo
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* add option to enable scalafmt for code formatting * fix typo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.3.x,4.0.x. Default:master.Description of the PR
Format Scala code by simply creating an environment variable, e.g.
export SCALAFMT_PATH=/usr/local/bin/scalafmtI've only run
./bin/scala-akka-petstore.shto update the Scala Akka Petstore sample to demonstrate the formatted Scala code.We'll undo these changes before merging into master.
cc @clasnake @jimschubert @shijinkui @ramzimaalej