Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Java][Retrofit2] The part name is not added to the annotation #1029

Merged
merged 3 commits into from
Sep 16, 2018

Conversation

cheparinV
Copy link
Contributor

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

Description of the PR

this patch fixes #1013

(details of the change, additional tests that have been done, reference to the issue for tracking, etc)

Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The fix looks good to me although I've not tested it locally

@wing328
Copy link
Member

wing328 commented Sep 14, 2018

cc @bbdouglas (2017/07) @JFCote (2017/08) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01)

@wing328 wing328 merged commit 5fc76ba into OpenAPITools:master Sep 16, 2018
jaumard pushed a commit to jaumard/openapi-generator that referenced this pull request Sep 21, 2018
…PITools#1029)

* fixed retrofit2/formParams.mustache

* added play26 to retrofit2-all.sh

* fixed samples
@wing328
Copy link
Member

wing328 commented Oct 2, 2018

@cheparinV thanks again for the PR, which is included in the v3.3.0 minor release: https://twitter.com/oas_generator/status/1046941449609068544

A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
…PITools#1029)

* fixed retrofit2/formParams.mustache

* added play26 to retrofit2-all.sh

* fixed samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Java][retrofit2] Add the part name in the annotation for MultipartBody.Part.
2 participants