Bug fix: Kotlin generator doesn't support inheritance #1026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
irishshagua
force-pushed
the
issue_1025
branch
from
49303f6
to
45a1cd6
Compare
|
LGTM: @jimschubert any thoughts? |
wing328
reviewed
Sep 18, 2018
| @@ -498,4 +502,16 @@ public void execute(Template.Fragment fragment, Writer writer) throws IOExceptio | |||
| writer.write(fragment.execute().replaceAll(from, to)); | |||
| } | |||
| } | |||
|
|
|||
| // Can't figure out the logic in DefaultCodegen but optional vars are getting duplicated when there's | |||
There was a problem hiding this comment.
Agreed with you it should be done in DefautlCodegen. I'll try to figure out a fix later in DefaultCodegen so as to fix the issue for other generators as well.
|
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
Current master is 3.3.0 as we merged 3.3.x into master previously to prepare for the release. |
wing328
approved these changes
Sep 18, 2018
* allVars is duplicating child preoperties when models are inherited. Filter out these duplicates in the KotlinSpringServerCodegen * isInherited property was not being populated in the CodegenModel, re-parse the models in the KotlinSpringServerCodegen class and populate the property here * Add template support for Kotlin models which require inheritance from a base class to support oneOf declarations in the api yaml * Change optional for parameters to use Kotlins nullable * Update petstore api with Optional -> Nullable
irishshagua
force-pushed
the
issue_1025
branch
from
45a1cd6
to
4042706
Compare
|
Cheers @wing328, changed the git author now... |
jaumard
pushed a commit
to jaumard/openapi-generator
that referenced
this pull request
Sep 21, 2018
…s#1026) * allVars is duplicating child preoperties when models are inherited. Filter out these duplicates in the KotlinSpringServerCodegen * isInherited property was not being populated in the CodegenModel, re-parse the models in the KotlinSpringServerCodegen class and populate the property here * Add template support for Kotlin models which require inheritance from a base class to support oneOf declarations in the api yaml * Change optional for parameters to use Kotlins nullable * Update petstore api with Optional -> Nullable
wing328
changed the title
|
@irishshagua thanks again for the PR, which is included in the v3.3.0 minor release: https://twitter.com/oas_generator/status/1046941449609068544 |
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
…s#1026) * allVars is duplicating child preoperties when models are inherited. Filter out these duplicates in the KotlinSpringServerCodegen * isInherited property was not being populated in the CodegenModel, re-parse the models in the KotlinSpringServerCodegen class and populate the property here * Add template support for Kotlin models which require inheritance from a base class to support oneOf declarations in the api yaml * Change optional for parameters to use Kotlins nullable * Update petstore api with Optional -> Nullable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.3.x,4.0.x. Default:master.@jimschubert @dr4ke616
Description of the PR
Kinda fix for Issue 1025