Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Java][Jersey] add @Valid when bean validation is enabled #1019

Merged
merged 6 commits into from
Sep 16, 2018
Merged

[Java][Jersey] add @Valid when bean validation is enabled #1019

merged 6 commits into from
Sep 16, 2018

Conversation

fujigon
Copy link
Contributor

@fujigon fujigon commented Sep 12, 2018 •
edited
Loading

PR checklist

  • Read the contribution guidelines.
  • Ran the shell script under ./bin/ to update Petstore sample so that CIs can verify the change. (For instance, only need to run ./bin/{LANG}-petstore.sh and ./bin/security/{LANG}-petstore.sh if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in .\bin\windows\.
  • Filed the PR against the correct branch: master, 3.3.x, 4.0.x. Default: master.
  • Copied the technical committee to review the pull request if your PR is targeting a particular programming language.

@bbdouglas @JFCote @sreeshas @jfiala @lukoyanov @cbornet @jeff9finger
@wing328

Description of the PR

This patch fixes #1018

  • fix pojo and beanParams template in java-jersey to have @Valid when use bean validation
  • re-generate sample

@fujigon fujigon changed the title Feature/java jersey validation pojos [Java][Jersey] add @Valid when bean validation is enabled Sep 12, 2018
@fujigon fujigon mentioned this pull request Sep 13, 2018
Closed
@wing328 wing328 added this to the 3.3.0 milestone Sep 14, 2018
wing328
wing328 approved these changes Sep 14, 2018
View reviewed changes
Copy link
Member

@wing328 wing328 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@wing328 wing328 merged commit 5c794a0 into OpenAPITools:master Sep 16, 2018
@fujigon fujigon deleted the feature/java-jersey-validation-pojos branch September 18, 2018 01:35
jaumard pushed a commit to jaumard/openapi-generator that referenced this pull request Sep 21, 2018
@fujigon @jaumard
[Java][Jersey] add @Valid when bean validation is enabled (OpenAPIToo…
650a481 
…ls#1019)

* fix template to add @Valid to POJO fields regarding nest, in java-jersey

* regenerate with for scr in `ls ./bin/*jersey*.sh`; do sh $scr; done

* re-generate with ./bin/openapi3/jaxrs-jersey-petstore.sh

* update api template for jersey1

* re-generate samples

* re-generate samples
@wing328
Copy link
Member

wing328 commented Oct 2, 2018

@fujigon thanks again for the PR, which is included in the v3.3.0 minor release: https://twitter.com/oas_generator/status/1046941449609068544

@tnmtechnologies tnmtechnologies mentioned this pull request Oct 9, 2018
Closed
@tnmtechnologies tnmtechnologies mentioned this pull request Dec 17, 2018
Closed
A-Joshi pushed a commit to ihsmarkitoss/openapi-generator that referenced this pull request Feb 27, 2019
@fujigon @wing328
[Java][Jersey] add @Valid when bean validation is enabled (OpenAPIToo…
ff92b0e 
…ls#1019)

* fix template to add @Valid to POJO fields regarding nest, in java-jersey

* regenerate with for scr in `ls ./bin/*jersey*.sh`; do sh $scr; done

* re-generate with ./bin/openapi3/jaxrs-jersey-petstore.sh

* update api template for jersey1

* re-generate samples

* re-generate samples
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wing328 wing328 wing328 approved these changes

Assignees
No one assigned
Labels
Enhancement: General Server: Java
Projects
None yet
Milestone
3.3.0
Development

Successfully merging this pull request may close these issues.

[Java][Jersey] Add support for BeanValidation @Valid annotation
2 participants
@fujigon @wing328