Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add map property in url params #10154

Merged
merged 2 commits into from
Aug 17, 2021

Conversation

agilob
Copy link
Contributor

@agilob agilob commented Aug 14, 2021

Adding map property in url params to test generation of this specific case in generators as requested in #10116 (comment)

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328

@kuhnroyal
Copy link
Contributor

Damn, I did this yesterday but didn't open a PR cause of the 5.2.1 release :)

@kuhnroyal
Copy link
Contributor

Can you copy the tests from https://github.com/kuhnroyal/openapi-generator/tree/dart-dio/query-maps

@agilob
Copy link
Contributor Author

agilob commented Aug 16, 2021

It's hard to distil your change and find what's dart-test change you want added and what is generated, but I think I found what was missing

@kuhnroyal
Copy link
Contributor

Looks about right, just needs some formatting.

@agilob
Copy link
Contributor Author

agilob commented Aug 16, 2021

Is that test supposed to be failing?

@kuhnroyal
Copy link
Contributor

Is that test supposed to be failing?

I think this is just a formatting failure. Can you run dart format . in the test project?

@agilob
Copy link
Contributor Author

agilob commented Aug 16, 2021

I removed the commits adding the dart tests. They are failing locally and I feel they are out of scope for this PR, as I only wanted to add spec changes without anything language specific. I'll let you add the tests as you want, I think I missed some changes from your PR...

@wing328 wing328 added this to the 5.3.0 milestone Aug 17, 2021
@wing328 wing328 merged commit 7edddb6 into OpenAPITools:master Aug 17, 2021
@agilob agilob deleted the add-map-property-in-url branch August 17, 2021 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants