Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cpp-pistache-server] Fix missing semicolon in template and missing code to set default values of model schema #10136

Merged
merged 3 commits into from
Aug 14, 2021

Conversation

shayan-eftekhari
Copy link
Contributor

fix #10134
fix #10135

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd

@shayan-eftekhari
Copy link
Contributor Author

Hello dear technical committee,

This is my first contribution to this project and I don't understand what caused the checks to fail. Would you please give me some hints and/or action points?

@ravinikam @stkrwork @etherealjoy @MartinDelille @muttleyxd

@wing328
Copy link
Member

wing328 commented Aug 13, 2021

CI issues not related to this change.

@wing328
Copy link
Member

wing328 commented Aug 13, 2021

LGTM. If no further question from anyone, I'll merge it over the weekend.

@wing328 wing328 added this to the 5.2.1 milestone Aug 13, 2021
@wing328 wing328 changed the title Fix #10134 and Fix #10135: Missing semicolon in cpp-pistache-server template and missing code in cpp-pistache-server to set default values of model schema [cpp-pistache-server] Missing semicolon in template and missing code to set default values of model schema Aug 13, 2021
@wing328 wing328 changed the title [cpp-pistache-server] Missing semicolon in template and missing code to set default values of model schema [cpp-pistache-server] Fix missing semicolon in template and missing code to set default values of model schema Aug 13, 2021
@wing328 wing328 merged commit 8569ff8 into OpenAPITools:master Aug 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment