Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[C][Client] Allocate memory for the element of array when the type is number #10124

Merged
merged 1 commit into from
Aug 11, 2021

Conversation

ityuhui
Copy link
Contributor

@ityuhui ityuhui commented Aug 10, 2021

If the type of element of an array is number, e.g.

        "supplementalGroups": {
          "description": "A list of groups applied to the first process run in each container, in addition to the container's primary GID.  If unspecified, no groups will be added to any container.",
          "items": {
            "format": "int64",
            "type": "integer"
          },
          "type": "array"
        },

The current template code of CLibcurl will not allocate memory for the element before adding it to a list:

    list_addElement(supplemental_groupsList , &supplemental_groups_local->valuedouble);

supplemental_groups_local is a local variable, it will be released soon. And then the pointer pointing to supplemental_groups_local->valuedouble will be invalid.

This PR allocates memory for the element:

    double *supplemental_groups_local_value = (double *)calloc(1, sizeof(double));
    if(!supplemental_groups_local_value)
    {
        goto end;
    }
    *supplemental_groups_local_value = supplemental_groups_local->valuedouble;
    list_addElement(supplemental_groupsList , supplemental_groups_local_value);

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the master: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Hi @wing328 @zhemant @michelealbano

Could you please review this PR ? Thanks.

@zhemant
Copy link
Contributor

zhemant commented Aug 10, 2021

Thank you for the PR @ityuhui

By any chance do you have a test code that I can try? If we have an issue described in this PR, I think we would have to update boolean as well in primitive containers and numeric and boolean in map parsing.

For boolean we are currently doing same: list_addElement({{{name}}}List , {{{name}}}_local->valueint);

@ityuhui
Copy link
Contributor Author

ityuhui commented Aug 11, 2021

I don't have a test code, the issue comes from kubernetes-client/c#59 and kubernetes-client/c#70

I think boolean array has this issue too but we don't have any Swagger/OpenAPI spec.
So I prefer only fixing the issue of "number array"in this PR because the fix will be verified by the above 2 issues.

@zhemant
Copy link
Contributor

zhemant commented Aug 11, 2021

Okay, let's fix this for now, and we can fix others as and when we come across them.

Copy link
Contributor

@zhemant zhemant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ityuhui
Copy link
Contributor Author

ityuhui commented Aug 11, 2021

Thank you @zhemant !

@wing328 wing328 merged commit bd8efe2 into OpenAPITools:master Aug 11, 2021
@wing328 wing328 added this to the 5.2.1 milestone Aug 11, 2021
@ityuhui
Copy link
Contributor Author

ityuhui commented Aug 11, 2021

Thank you @wing328 !

@ityuhui ityuhui deleted the yh-number-array branch August 11, 2021 13:30
ekilmer added a commit to ekilmer/openapi-generator that referenced this pull request Aug 16, 2021
* master: (849 commits)
  Don't use encodeCollectionQueryParameter on maps (OpenAPITools#10116)
  Fixed the utc time issue for httpSigning auth. (OpenAPITools#10139)
  [dart][dio] Update built_value to =>8.1.0 (OpenAPITools#10122)
  Add Inquisico to list of generator users (OpenAPITools#10142)
  add my companies to README (OpenAPITools#10146)
  [C][Client] Allocate memory for the element of array when the type is number (OpenAPITools#10124)
  update samples
  Fixed typo in csharp-netcore httpclient generated code (OpenAPITools#10119)
  Typescript-angular: Added missing semi colon to interface export in `apis.ts` template file. (OpenAPITools#10121)
  Fix issue 10020: [BUG] [typescript-angular] Add "header" to reserved words (OpenAPITools#10091)
  Add missing samples for OpenAPITools#9857
  [typescript] FIX: Generate documentation and examples OpenAPITools#9413 (OpenAPITools#9857)
  Feat adds has discriminator with non empty mapping (OpenAPITools#9667)
  Add switches (authentication collections) to support files (OpenAPITools#9884)
  [dart-dio-next] improve encodeCollectionQueryParameter to handle cases where collectionFormat is null (OpenAPITools#10105)
  [go-server] Feat: add required assertions to models (OpenAPITools#10068)
  [dart2] Include request body on DELETE call (OpenAPITools#10100)
  Make php's array a primitive (OpenAPITools#10093)
  Fix typo (preffer -> prefer) (OpenAPITools#10098)
  Fix typo on rust client (OpenAPITools#10096)
  ...
acodereviewersbestfriend544 added a commit to acodereviewersbestfriend544/c that referenced this pull request Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants