[gradle plugin] Support Gradle 4.10 #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gradle 4.10 is bundled with Kotlin 1.60 and Kotlin DSL 1.0-rc1. The new Kotlin DSL isn't binary compatible with the `tasks` registration used in this plugin. Updating to Kotlin DSL 1.0-rc1 with no other changes would require users to update to Gradle 4.10. As a workaround, I've modified the tasks registration being done in OpenApiGeneratorPlugin.kt, so rather than using the Kotlin DSL's invoke, it creates tasks manually against the TasksContainer. This works locally with Gradle 4.7+ for all scenarios in the sample (samples/local-spec). There may be edge cases that I'm unaware of, and we may want to consider defining the minimum supported Gradle version of 4.10 in the next major version of openapi-generator-gradle-plugin if we experience those cases.
|
👌 |
wing328
added a commit
that referenced
this pull request
Sep 13, 2018
jaumard
pushed a commit
to jaumard/openapi-generator
that referenced
this pull request
Sep 21, 2018
* Support Gradle 4.10 Gradle 4.10 is bundled with Kotlin 1.60 and Kotlin DSL 1.0-rc1. The new Kotlin DSL isn't binary compatible with the `tasks` registration used in this plugin. Updating to Kotlin DSL 1.0-rc1 with no other changes would require users to update to Gradle 4.10. As a workaround, I've modified the tasks registration being done in OpenApiGeneratorPlugin.kt, so rather than using the Kotlin DSL's invoke, it creates tasks manually against the TasksContainer. This works locally with Gradle 4.7+ for all scenarios in the sample (samples/local-spec). There may be edge cases that I'm unaware of, and we may want to consider defining the minimum supported Gradle version of 4.10 in the next major version of openapi-generator-gradle-plugin if we experience those cases. * Uncomment snapshots repo (commented it during local testing) * update pom.xml for exec gradle plugin
jaumard
pushed a commit
to jaumard/openapi-generator
that referenced
this pull request
Sep 21, 2018
…r" (OpenAPITools#1027) * Revert "[gradle plugin] Support Gradle 4.10 (OpenAPITools#1011)" This reverts commit 131cf94. * Revert "[C++][Restbed] Fix default values for Restbed Server generator (OpenAPITools#761)" This reverts commit f29ba97.
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
* Support Gradle 4.10 Gradle 4.10 is bundled with Kotlin 1.60 and Kotlin DSL 1.0-rc1. The new Kotlin DSL isn't binary compatible with the `tasks` registration used in this plugin. Updating to Kotlin DSL 1.0-rc1 with no other changes would require users to update to Gradle 4.10. As a workaround, I've modified the tasks registration being done in OpenApiGeneratorPlugin.kt, so rather than using the Kotlin DSL's invoke, it creates tasks manually against the TasksContainer. This works locally with Gradle 4.7+ for all scenarios in the sample (samples/local-spec). There may be edge cases that I'm unaware of, and we may want to consider defining the minimum supported Gradle version of 4.10 in the next major version of openapi-generator-gradle-plugin if we experience those cases. * Uncomment snapshots repo (commented it during local testing) * update pom.xml for exec gradle plugin
A-Joshi
pushed a commit
to ihsmarkitoss/openapi-generator
that referenced
this pull request
Feb 27, 2019
…r" (OpenAPITools#1027) * Revert "[gradle plugin] Support Gradle 4.10 (OpenAPITools#1011)" This reverts commit 131cf94. * Revert "[C++][Restbed] Fix default values for Restbed Server generator (OpenAPITools#761)" This reverts commit f29ba97.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gradle 4.10 is bundled with Kotlin 1.60 and Kotlin DSL 1.0-rc1. The new
Kotlin DSL isn't binary compatible with the
tasksregistration used inthis plugin.
Updating to Kotlin DSL 1.0-rc1 with no other changes would require users
to update to Gradle 4.10.
As a workaround, I've modified the tasks registration being done in
OpenApiGeneratorPlugin.kt, so rather than using the Kotlin DSL's invoke,
it creates tasks manually against the TasksContainer. This works locally
with Gradle 4.7+ for all scenarios in the sample (samples/local-spec).
There may be edge cases that I'm unaware of, and we may want to consider
defining the minimum supported Gradle version of 4.10 in the next major
version of openapi-generator-gradle-plugin if we experience those cases.
See #962
PR checklist
./bin/to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.shand./bin/security/{LANG}-petstore.shif updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\.master,3.3.x,4.0.x. Default:master.