-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dart2]: improved error reporting #1006
Conversation
Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors. Let me know if you need help fixing it. |
@wing328 Fixed. |
@ircecho looks good now. May I know if you've
and then update the samples again so that the Dart code will have better format. (This is a new feature we added recently. Please let us know if you've any feedback) |
@wing328 Fixed. My only suggestion to this feature would be to use dartfmt automatically, if it is available in the path. I thought that was the case which is why I did not bother to check. Anyways, now the formatting should be fine. |
@ircecho thanks for the suggestion. Later we may update the logic to search for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch!
* fix[dart]: improved error reporting * rebuilt dart2 petstore * rebuilt dart2 petstore with dartfmt
* fix[dart]: improved error reporting * rebuilt dart2 petstore * rebuilt dart2 petstore with dartfmt
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.3.x
,4.0.x
. Default:master
.@ircecho (2017/07) @swipesight (2018/09)
Description of the PR
(details of the change, additional tests that have been done, reference to the issue for tracking, etc)
Fixed catch in ApiClient to properly display exceptions and errors.
Original error is gobbled, overshadowed by exception in catch block.
becomes
Original error is visible properly.