Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ jaxrs-resteasy] fix java8 datetime issue #10014

Merged

Conversation

autodidacticon
Copy link
Contributor

@autodidacticon autodidacticon commented Jul 22, 2021

Addresses #5584

updates jaxrs-resteasy pom and jaxrs-resteasy jacksonconfig templates

added samples for jaxrs-resteasy java8 server generation

PR checklist

  • Read the contribution guidelines.
  • Pull Request title clearly describes the work in the pull request and Pull Request description provides details about how to validate the work. Missing information here may result in delayed response from the community.
  • Run the following to build the project and update samples:
    ./mvnw clean package 
    ./bin/generate-samples.sh
    ./bin/utils/export_docs_generators.sh
    
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    For Windows users, please run the script in Git BASH.
  • File the PR against the correct branch: master, 5.3.x, 6.0.x
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@wing328 wing328 added this to the 5.2.1 milestone Jul 23, 2021
@autodidacticon autodidacticon changed the title fix java8 datetime jaxrs-resteasy fix java8 datetime jaxrs-resteasy server Jul 23, 2021
@autodidacticon
Copy link
Contributor Author

@wing328 Latest build is failing on seemingly unrelated content. Is there a way to reexecute the build or have my changes somehow disturbed the failing sample?

@wing328
Copy link
Member

wing328 commented Jul 24, 2021

Thanks for the PR but your commit (as shown in the Commits tab) is not linked to your Github account, which means this PR won't count as your contribution in https://github.com/OpenAPITools/openapi-generator/graphs/contributors.

Let me know if you need help fixing it.

Ref: https://github.com/OpenAPITools/openapi-generator/wiki/FAQ#how-can-i-update-commits-that-are-not-linked-to-my-github-account

@autodidacticon
Copy link
Contributor Author

Good catch; fixed and thank you.

@wing328
Copy link
Member

wing328 commented Jul 25, 2021

cc @bbdouglas (2017/07) @sreeshas (2017/08) @jfiala (2017/08) @lukoyanov (2017/09) @cbornet (2017/09) @jeff9finger (2018/01) @karismann (2019/03) @Zomzog (2019/04) @lwlee2608 (2019/10) @nmuesch (2021/01)

@wing328 wing328 changed the title fix java8 datetime jaxrs-resteasy server [ jaxrs-resteasy] fix java8 datetime issue Jul 27, 2021
@wing328 wing328 merged commit ddd23ab into OpenAPITools:master Jul 27, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants