-
-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a CLI option to control logging level #1000
Conversation
#1000 👀 |
This PR is not targeting a particular programming language. |
@ackintosh thanks for the enhancement, which definitely makes it easier to debug OpenAPI Generator (in addition to providing a configuration file) Instead of using Let's see if others have comments on this as well. |
I agree that it's probably better as |
Thanks for the suggestion. It looks better to me as well. ✨ |
I've updated the property name. Please have a look when you have time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
* Add CLI option to control logging level * Update the property name
* Add CLI option to control logging level * Update the property name
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.master
,3.3.x
,4.0.x
. Default:master
.Description of the PR
closes #989
This PR makes logging level controllable with the property as below.