Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG][JavaScript] client generator: Reserved words detector is not case-sensitive #8904

Closed
5 tasks done
delenius opened this issue Mar 5, 2021 · 0 comments · Fixed by #8905
Closed
5 tasks done

[BUG][JavaScript] client generator: Reserved words detector is not case-sensitive #8904

delenius opened this issue Mar 5, 2021 · 0 comments · Fixed by #8905

Comments

@delenius
Copy link
Contributor

delenius commented Mar 5, 2021

Bug Report Checklist

  • Have you provided a full/minimal spec to reproduce the issue?
  • Have you validated the input using an OpenAPI validator (example)?
  • Have you tested with the latest master to confirm the issue still exists?
  • Have you searched for related issues/PRs?
  • What's the actual output vs expected output?
Description

The JS client generator is case-insensitive when it comes to detecting reserved words, while JavaScript itself is not.
For example, it complains about 'InstanceOf' as a model name, and renames it to 'ModelInstanceOf'.

openapi-generator version

5.1.0-SNAPSHOT, commit 976b4aa757e989fbaa28f92a721ade39735332e6.

OpenAPI declaration file content or url

See full details in this test repo.

Suggest a fix

The culprit is this line in DefaultCodegen.java:

    protected boolean isReservedWord(String word) {
        return word != null && reservedWords.contains(word.toLowerCase(Locale.ROOT));
    }

Removing .toLowerCase here should fix the problem. I will submit a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant