Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REQ][JAVA][webclient] query parameters are not encoded #8038

Open
matesmajda opened this issue Nov 27, 2020 · 2 comments
Open

[REQ][JAVA][webclient] query parameters are not encoded #8038

matesmajda opened this issue Nov 27, 2020 · 2 comments

Comments

@matesmajda
Copy link

matesmajda commented Nov 27, 2020

This PR removed the query parameter double encoding.
Issue link

But instead of removing only one iteration of encoding from the double encoding, it removed both, so instead of double encoded parameters now they are not encoded at all.

The problem is with this line. UriComponentsBuilder.build() method does not encode properly. See this SO issue.

Proposal:

  • change it back to builder.encode().toUriString()

  • or make it configurable to encode the parameters.

I can create a PR if we agree on which is the preferred way.

@wing328
Copy link
Member

wing328 commented Nov 28, 2020

@matesmajda please file a PR and we'll review accordingly.

tivadarbocz added a commit to tivadarbocz/openapi-generator that referenced this issue Dec 12, 2020
@UnleashSpirit
Copy link
Contributor

Already fixed with #8660
No ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants