[BUG] [JAVA] OAS3 incorrect data type when providing a default value

[kevinparaport]

Bug Report Checklist

• Have you provided a full/minimal spec to reproduce the issue?
• Have you validated the input using an OpenAPI validator (example)?
• Have you tested with the latest master to confirm the issue still exists?
• Have you searched for related issues/PRs?
• What's the actual output vs expected output?
• [Optional] Sponsorship to speed up the bug fix or feature request (example)

Description

When providing a default value, UI is saying the value is a string when it's an integer. Example JSON shows the variable as the correct data type though.

openapi-generator version

5.3.1

OpenAPI declaration file content or url

        - name: page
          in: query
          description: Zero-based page index of results to return
          required: false
          schema:
            type: integer
            format: int32
            default: 100

Generation Details

Using OAS3 = true

Related issues/PRs

#9775

Suggest a fix/enhancement

My guess is that the OAS3 changes for Java just aren't setting the type correctly in the mustache templates.

[kevinparaport]

@cachescrubber it seems like you've been working on the OAS3 issues quite a bit. Let me know if there's anything I can do to help.

[cachescrubber]

@kevinparaport You might want to review / test #11258. This PR should complete the OAS story.

[cachescrubber]

@kevinparaport Is the OpenApi spec generated by SpringDoc?

[kevinparaport]

@cachescrubber I upgraded to 5.4.0 and this is still an issue.

Here are the properties I'm using:
"oas3" to "true",
"useSpringController" to "true",
"useSpringfox" to "false",
"documentationProvider" to "springdoc",
"springDocDocumentationProvider" to "true",

[cachescrubber]

Yep, I see the issue here. The @Schema() annotation hides the default SpringDoc could otherwise deduct from the @RequestParam annotation.

@Parameter(name = "page", description = "Zero-based page index of results to return", schema = @Schema(type = "foo", description = "", defaultValue = "100")) @Valid @RequestParam(value = "page", required = false, defaultValue = "100") Integer page

Simply remove the @Schema from @Parameter would fix things.

@welshm what Do you think? I would currently opt to remove @Schema.

[cachescrubber]

@kevinparaport

"documentationProvider" to "springdoc"

Would be enough. You should remove oas3 and useSpringfox. springDocDocumentationProvider will be set automatically.

[welshm]

An issue with removing @Schema is that it enforces enum types (with allowableValues) - if the defaultVlaue field is removed from @Schema does SpringDoc behave as expected?

Could also try setting type field as aprt of @Schema - https://docs.swagger.io/swagger-core/v2.1.0/apidocs/io/swagger/v3/oas/annotations/media/Schema.html - although not sure if SpringDoc is respecting this field either

[cachescrubber]

I filed #11526. @kevinparaport, please give it a try if you can.

@welshm I came to the conclusion that in it's current incarnation the @Schema annotation inside @Parameter does more harm then good - hence I removed it.

If you have a valid use-case for it it let's discuss it here. Probably a new feature PR would be appropriate?