Add handling for parsing optional bool params & regenerate samples (#…

…14550)
OpenAPITools · Jan 30, 2023 · 8540c82 · 8540c82
1 parent b538c2a
commit 8540c82
Show file tree

Hide file tree

Showing 5 changed files with 37 additions and 5 deletions.
diff --git a/modules/openapi-generator/src/main/resources/go-server/controller-api.mustache b/modules/openapi-generator/src/main/resources/go-server/controller-api.mustache
@@ -124,7 +124,7 @@ func (c *{{classname}}Controller) {{nickname}}(w http.ResponseWriter, r *http.Re
 	}
 	{{/isInteger}}
 	{{#isBoolean}}
-	{{paramName}}Param, err := parseBoolParameter(query.Get("{{baseName}}"))
+	{{paramName}}Param, err := parseBoolParameter(query.Get("{{baseName}}"), {{required}})
 	if err != nil {
 		w.WriteHeader(500)
 		return

diff --git a/modules/openapi-generator/src/main/resources/go-server/routers.mustache b/modules/openapi-generator/src/main/resources/go-server/routers.mustache
@@ -199,7 +199,15 @@ func parseInt32Parameter(param string, required bool) (int32, error) {
 }
 
 // parseBoolParameter parses a string parameter to a bool
-func parseBoolParameter(param string) (bool, error) {
+func parseBoolParameter(param string, required bool) (bool, error) {
+	if param == "" {
+		if required {
+			return false, errors.New(errMsgRequiredMissing)
+		}
+
+		return false, nil
+	}
+
 	val, err := strconv.ParseBool(param)
 	if err != nil {
 		return false, err

diff --git a/samples/server/petstore/go-api-server/go/routers.go b/samples/server/petstore/go-api-server/go/routers.go
@@ -167,7 +167,15 @@ func parseInt32Parameter(param string, required bool) (int32, error) {
 }
 
 // parseBoolParameter parses a string parameter to a bool
-func parseBoolParameter(param string) (bool, error) {
+func parseBoolParameter(param string, required bool) (bool, error) {
+	if param == "" {
+		if required {
+			return false, errors.New(errMsgRequiredMissing)
+		}
+
+		return false, nil
+	}
+
 	val, err := strconv.ParseBool(param)
 	if err != nil {
 		return false, err

diff --git a/samples/server/petstore/go-chi-server/go/routers.go b/samples/server/petstore/go-chi-server/go/routers.go
@@ -163,7 +163,15 @@ func parseInt32Parameter(param string, required bool) (int32, error) {
 }
 
 // parseBoolParameter parses a string parameter to a bool
-func parseBoolParameter(param string) (bool, error) {
+func parseBoolParameter(param string, required bool) (bool, error) {
+	if param == "" {
+		if required {
+			return false, errors.New(errMsgRequiredMissing)
+		}
+
+		return false, nil
+	}
+
 	val, err := strconv.ParseBool(param)
 	if err != nil {
 		return false, err

diff --git a/samples/server/petstore/go-server-required/go/routers.go b/samples/server/petstore/go-server-required/go/routers.go
@@ -163,7 +163,15 @@ func parseInt32Parameter(param string, required bool) (int32, error) {
 }
 
 // parseBoolParameter parses a string parameter to a bool
-func parseBoolParameter(param string) (bool, error) {
+func parseBoolParameter(param string, required bool) (bool, error) {
+	if param == "" {
+		if required {
+			return false, errors.New(errMsgRequiredMissing)
+		}
+
+		return false, nil
+	}
+
 	val, err := strconv.ParseBool(param)
 	if err != nil {
 		return false, err