[crystal-lang] Resolve type check compile error in ApiError (#18759)

* Even with .nil? typecheck, compiler still fails due to .empty? call on nillable type. This appears a poor implementation issue by crystal-lang, but this explicit try avoids the issue for now. * Made call more succinct.
OpenAPITools · May 26, 2024 · 77365c3 · 77365c3
1 parent e6fcbcb
commit 77365c3
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/modules/openapi-generator/src/main/resources/crystal/api_error.mustache b/modules/openapi-generator/src/main/resources/crystal/api_error.mustache
@@ -21,7 +21,7 @@ module {{moduleName}}
       msg = ""
       msg = msg + "\nHTTP status code: #{code}" if @code
       msg = msg + "\nResponse headers: #{response_headers}" if @response_headers
-      if @message.nil? || @message.empty?
+      if @message.try &.empty?
         msg = msg + "\nError message: the server returns an error but the HTTP response body is empty."
       else
         msg = msg + "\nResponse body: #{@message}"

diff --git a/samples/client/petstore/crystal/src/petstore/api_error.cr b/samples/client/petstore/crystal/src/petstore/api_error.cr
@@ -29,7 +29,7 @@ module Petstore
       msg = ""
       msg = msg + "\nHTTP status code: #{code}" if @code
       msg = msg + "\nResponse headers: #{response_headers}" if @response_headers
-      if @message.nil? || @message.empty?
+      if @message.try &.empty?
         msg = msg + "\nError message: the server returns an error but the HTTP response body is empty."
       else
         msg = msg + "\nResponse body: #{@message}"