Skip to content

Commit

Permalink
[go-server] Fix: name declared and not used (#15201)
Browse files Browse the repository at this point in the history
* Fix: name declared and not used

* Update samples

* Re-enable workflow
  • Loading branch information
lwj5 committed Apr 13, 2023
1 parent 935146d commit 1163b9c
Show file tree
Hide file tree
Showing 4 changed files with 6 additions and 6 deletions.
6 changes: 3 additions & 3 deletions .github/workflows/samples-go.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -5,12 +5,12 @@ on:
paths:
- 'samples/server/petstore/go-echo-server/**'
- 'samples/server/petstore/go-api-server/**'
#- 'samples/server/petstore/go-chi-server/**'
- 'samples/server/petstore/go-chi-server/**'
pull_request:
paths:
- 'samples/server/petstore/go-echo-server/**'
- 'samples/server/petstore/go-api-server/**'
#- 'samples/server/petstore/go-chi-server/**'
- 'samples/server/petstore/go-chi-server/**'

jobs:
build:
Expand All @@ -22,7 +22,7 @@ jobs:
sample:
- samples/server/petstore/go-echo-server/
- samples/server/petstore/go-api-server/
#- samples/server/petstore/go-chi-server/
- samples/server/petstore/go-chi-server/
steps:
- uses: actions/checkout@v3
- uses: actions/setup-go@v4
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -59,7 +59,7 @@ func NewRouter(routers ...Router) {{#routers}}{{#mux}}*mux.Router{{/mux}}{{#chi}
{{/chi}}
{{/routers}}
for _, api := range routers {
for name, route := range api.Routes() {
for {{#routers}}{{#mux}}name{{/mux}}{{#chi}}_{{/chi}}{{/routers}}, route := range api.Routes() {
var handler http.Handler
handler = route.HandlerFunc
{{#routers}}
Expand Down
2 changes: 1 addition & 1 deletion samples/server/petstore/go-chi-server/go/routers.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func NewRouter(routers ...Router) chi.Router {
router := chi.NewRouter()
router.Use(middleware.Logger)
for _, api := range routers {
for name, route := range api.Routes() {
for _, route := range api.Routes() {
var handler http.Handler
handler = route.HandlerFunc
router.Method(route.Method, route.Pattern, handler)
Expand Down
2 changes: 1 addition & 1 deletion samples/server/petstore/go-server-required/go/routers.go
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ func NewRouter(routers ...Router) chi.Router {
router := chi.NewRouter()
router.Use(middleware.Logger)
for _, api := range routers {
for name, route := range api.Routes() {
for _, route := range api.Routes() {
var handler http.Handler
handler = route.HandlerFunc
router.Method(route.Method, route.Pattern, handler)
Expand Down

0 comments on commit 1163b9c

Please sign in to comment.