Skip to content

Commit

Permalink
[MAVEN PLUGIN] Checking for null configOptions before looking for pro…
Browse files Browse the repository at this point in the history
…perty (#7613)

* Checking for null configOptions

* Inline configOptions check
  • Loading branch information
Matthew McGarvey authored and wing328 committed Feb 10, 2018
1 parent f41683a commit 0a28aad
Showing 1 changed file with 13 additions and 10 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,12 @@

/*
* Copyright 2001-2005 The Apache Software Foundation.
*
*
* Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except
* in compliance with the License. You may obtain a copy of the License at
*
*
* http://www.apache.org/licenses/LICENSE-2.0
*
*
* Unless required by applicable law or agreed to in writing, software distributed under the License
* is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express
* or implied. See the License for the specific language governing permissions and limitations under
Expand Down Expand Up @@ -210,6 +210,9 @@ public class CodeGenMojo extends AbstractMojo {

/**
* A map of additional properties that can be referenced by the mustache templates
* <additionalProperties>
* <additionalProperty>key=value</additionalProperty>
* </additionalProperties>
*/
@Parameter(name = "additionalProperties")
private List<String> additionalProperties;
Expand All @@ -218,7 +221,7 @@ public class CodeGenMojo extends AbstractMojo {
* A map of reserved names and how they should be escaped
*/
@Parameter(name = "reservedWordsMappings")
private List<String> reservedWordsMappings;
private List<String> reservedWordsMappings;

/**
* Generate the apis
Expand Down Expand Up @@ -466,32 +469,32 @@ public void execute() throws MojoExecutionException {
}

//Apply Instantiation Types
if (instantiationTypes != null && !configOptions.containsKey("instantiation-types")) {
if (instantiationTypes != null && (configOptions == null || !configOptions.containsKey("instantiation-types"))) {
applyInstantiationTypesKvpList(instantiationTypes, configurator);
}

//Apply Import Mappings
if (importMappings != null && !configOptions.containsKey("import-mappings")) {
if (importMappings != null && (configOptions == null || !configOptions.containsKey("import-mappings"))) {
applyImportMappingsKvpList(importMappings, configurator);
}

//Apply Type Mappings
if (typeMappings != null && !configOptions.containsKey("type-mappings")) {
if (typeMappings != null && (configOptions == null || !configOptions.containsKey("type-mappings"))) {
applyTypeMappingsKvpList(typeMappings, configurator);
}

//Apply Language Specific Primitives
if (languageSpecificPrimitives != null && !configOptions.containsKey("language-specific-primitives")) {
if (languageSpecificPrimitives != null && (configOptions == null || !configOptions.containsKey("language-specific-primitives"))) {
applyLanguageSpecificPrimitivesCsvList(languageSpecificPrimitives, configurator);
}

//Apply Additional Properties
if (additionalProperties != null && !configOptions.containsKey("additional-properties")) {
if (additionalProperties != null && (configOptions == null || !configOptions.containsKey("additional-properties"))) {
applyAdditionalPropertiesKvpList(additionalProperties, configurator);
}

//Apply Reserved Words Mappings
if (reservedWordsMappings != null && !configOptions.containsKey("reserved-words-mappings")) {
if (reservedWordsMappings != null && (configOptions == null || !configOptions.containsKey("reserved-words-mappings"))) {
applyReservedWordsMappingsKvpList(reservedWordsMappings, configurator);
}

Expand Down

0 comments on commit 0a28aad

Please sign in to comment.