Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: fix timezone and pip3 issues #294

Merged
merged 3 commits into from
May 13, 2024
Merged

CI: fix timezone and pip3 issues #294

merged 3 commits into from
May 13, 2024

Conversation

arnopo
Copy link
Contributor

@arnopo arnopo commented May 3, 2024

The build check fails with following errors:

  1. ln: failed to create symbolic link '/etc/localtime': File exists
    Fix it by removing the link creation

  2. error: externally-managed-environment
    Fix it by adding "--break-system-packages" option to pip3

Copy link
Collaborator

@tnmysh tnmysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@wmamills
Copy link
Contributor

wmamills commented May 4, 2024

Please wait until we agree on the way forward for open-amp and then we/I can update this one also.

@wmamills
Copy link
Contributor

wmamills commented May 6, 2024

@arnopo are you going to do this one or do you want me to? I had it started but I don't have the change to use venv

@arnopo
Copy link
Contributor Author

arnopo commented May 6, 2024

@arnopo are you going to do this one or do you want me to? I had it started but I don't have the change to use venv

Both are ok for me. I'm waiting that we fix open-amp. I did not start libmetal update yet.

arnopo added 3 commits May 7, 2024 15:12
* Lock to 24.04 so we control when to change
* Update locale and timezone to work for 24.04 or 22.04
  * 24.04 creates these files if not already there but 22.04 does not
  * Keep existing work around for 22.04 but make it work if already there
* use venv
  * Breate a virtual environment isolated from the packages in the base
    environment
  * Inspired from zephyr build environment
* Use pip3 everywhere removing global and --user installation

Signed-off-by: Arnaud Pouliquen <[email protected]>
Force the exit with value 1 when cmake or make command fails.

Signed-off-by: Arnaud Pouliquen <[email protected]>
The  https://cfhcable.dl.sourceforge.net/project/freertos/FreeRTOS/V10.0.1/FreeRTOSv10.0.1.zip
URL is no more valid

Update it to point to sourceforge.net

Signed-off-by: Arnaud Pouliquen <[email protected]>
@arnopo
Copy link
Contributor Author

arnopo commented May 7, 2024

I updated to use ubuntu 24.04 environement
I also fix dead link for the freeRTOS lib
the checkpatch error is due to the update of the FreeRTOS URL

@wmamills
Copy link
Contributor

wmamills commented May 8, 2024

I pulled this down and pushed to my main branch to test on github.
I get a failure on zephyr.
I also see that Linux gets the same failures I was seeing on the desktop testing but github does not count them as an error.
My job log is here:
https://github.com/wmamills/libmetal/actions/runs/9004301644/job/24736958627

@wmamills
Copy link
Contributor

wmamills commented May 8, 2024

The zephyr failure appears to be a temp failure of the github web server. I ran the same thing again and it worked OK for zephyr.
The linux test failures are still there. I switched to 22.04 for the docker image (on desktop) and they are still there.

@wmamills
Copy link
Contributor

wmamills commented May 11, 2024

The Linux failures are hard to figure out. Initially they failed on the desktop, now they pass without me changing anything. They still fail on github but this does not cause a problem right now as github workflow ignores the error.

I can't spend any more time on this right now so I suggest accepting this PR as is and we can fixup the Linux failures later (or delete them as they are redundant with the other test action).

FYI: I tested this commit to fix github ignoring the test results. It does allow the workflow to fail but I don't have a fix or explanation of the failure right now.
https://github.com/wmamills/libmetal/actions/runs/9020751918

@arnopo
Copy link
Contributor Author

arnopo commented May 13, 2024

The Linux failures are hard to figure out. Initially they failed on the desktop, now they pass without me changing anything. They still fail on github but this does not cause a problem right now as github workflow ignores the error.

Yes I suspect that the issue is there since a while. As the workflow don't test the output it ignore the issue.

I can't spend any more time on this right now so I suggest accepting this PR as is and we can fixup the Linux failures later (or delete them as they are redundant with the other test action).

i will try to have a look this week. Ok to treat this in a separate PR/issue

FYI: I tested this commit to fix github ignoring the test results. It does allow the workflow to fail but I don't have a fix or explanation of the failure right now. https://github.com/wmamills/libmetal/actions/runs/9020751918

@arnopo arnopo merged commit 0f1db10 into OpenAMP:main May 13, 2024
3 of 4 checks passed
@arnopo arnopo added this to the Release V2024.05 milestone May 20, 2024
@arnopo arnopo deleted the fix_CI branch May 20, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants