Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New routine to find a node on a list #217

Merged
merged 1 commit into from
Oct 4, 2022
Merged

Conversation

tammyleino
Copy link
Collaborator

metal_list_find_node is used to ensure a node is not on a list before adding it
Signed-off-by: Tammy Leino [email protected]

@tammyleino tammyleino force-pushed the openamp_400 branch 2 times, most recently from d3e5521 to 5680b70 Compare July 26, 2022 19:09
Copy link
Contributor

@arnopo arnopo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems that the checkpatch fail is a false positive. we can ignore it.
Minor comments.

lib/list.h Outdated Show resolved Hide resolved
lib/list.h Outdated Show resolved Hide resolved
lib/list.h Outdated Show resolved Hide resolved
@tammyleino tammyleino force-pushed the openamp_400 branch 2 times, most recently from 31ffdf0 to 526e321 Compare September 23, 2022 17:56
@tammyleino
Copy link
Collaborator Author

@arnopo I addressed your comments but am seeing the checkpatch failure still.

@arnopo
Copy link
Contributor

arnopo commented Sep 26, 2022

@arnopo I addressed your comments but am seeing the checkpatch failure still.

It is a false positif check patch. You can ignore it.

lib/list.h Show resolved Hide resolved
@arnopo arnopo added this to the Release V2022.10 milestone Oct 3, 2022
metal_list_find_node is used to ensure a node is not on a list before adding it
Signed-off-by: Tammy Leino <[email protected]>
Copy link
Contributor

@edmooring edmooring left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@arnopo arnopo merged commit c1c4e55 into OpenAMP:main Oct 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants