Create an eventfd object with EFD_CLOEXEC flag, to avoid leaking file descriptor to child processes
#204
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @Tosainu |
Tosainu
force-pushed
the
eventfd-cloexec
branch
from
55aa849
to
f504714
Compare
The file descriptor `irq_notify_fd` does not have the close-on-exec (`FD_CLOEXEC`) flag so it possibly leaks to child processes. This adds an `EFD_CLOEXEC` flag to the second argument of the `exentfd(2)` call, which tells it to set an `FD_CLOEXEC` flag on the new file descriptor. Signed-off-by: Kenta Sato <[email protected]>
Tosainu
force-pushed
the
eventfd-cloexec
branch
from
f504714
to
a623b80
Compare
|
Hello. Thanks for your comments. I fixed failed compliance checks. |
edmooring
approved these changes
May 6, 2022
arnopo
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The file descriptor
irq_notify_fddoes not have the close-on-exec (FD_CLOEXEC) flag so it possibly leaks to child processes.This pull request adds an
EFD_CLOEXECflag to the second argument of theexentfd(2)call, which tells it to set anFD_CLOEXECflag on the new file descriptor.