Skip to content

[backend] Remove hardcoded opensaml dependencies#3123

Merged
RomuDeuxfois merged 1 commit into
release/currentfrom
improvment/opensaml
May 9, 2025
Merged

[backend] Remove hardcoded opensaml dependencies#3123
RomuDeuxfois merged 1 commit into
release/currentfrom
improvment/opensaml

Conversation

@RomuDeuxfois

@RomuDeuxfois RomuDeuxfois commented May 6, 2025

Copy link
Copy Markdown
Member

Proposed changes

@RomuDeuxfois RomuDeuxfois force-pushed the improvment/opensaml branch from 52b9000 to b396818 Compare May 6, 2025 13:46
@codecov

codecov Bot commented May 6, 2025

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 1.20482% with 82 lines in your changes missing coverage. Please review.

Project coverage is 41.38%. Comparing base (5e61c61) to head (b396818).
Report is 11 commits behind head on release/current.

Files with missing lines Patch % Lines
...ava/io/openbas/config/security/OpenSamlConfig.java 1.81% 54 Missing ⚠️
...va/io/openbas/config/security/SecurityService.java 0.00% 25 Missing ⚠️
...main/java/io/openbas/config/AppSecurityConfig.java 0.00% 3 Missing ⚠️
Additional details and impacted files
@@                  Coverage Diff                  @@
##             release/current    #3123      +/-   ##
=====================================================
- Coverage              41.41%   41.38%   -0.03%     
+ Complexity              2346     2342       -4     
=====================================================
  Files                    693      695       +2     
  Lines                  21291    21286       -5     
  Branches                1453     1454       +1     
=====================================================
- Hits                    8817     8809       -8     
- Misses                 11977    11980       +3     
  Partials                 497      497              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@damgouj damgouj self-requested a review May 7, 2025 06:28

@damgouj damgouj left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refacto and tests Ok for me, thanks !

@RomuDeuxfois RomuDeuxfois merged commit 1407a03 into release/current May 9, 2025
8 checks passed
@RomuDeuxfois RomuDeuxfois deleted the improvment/opensaml branch May 9, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants