build(nix): fix postInstall
#347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the `installer` stage respecting PREFIX, the structure of DESTDIR is different. Therefore, installing files with `mv` runs into issues because directories cannot be merged using `mv`. For simplicity, we can use `cp` instead.
This was referenced Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the
installerstage respecting PREFIX, the structure of DESTDIR is different.Therefore, installing files with
mvruns into issues because directories cannot be merged usingmv.For simplicity, we can use
cpinstead.This fixes the regression in the nix flake package (#346) caused by #343.
IDK if #346 also affects other package or not though.
cc @beh-10257