-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: fix packaging #330
build: fix packaging #330
Conversation
428478b
to
c75a9b1
Compare
3fd7d20
to
e985a71
Compare
d92d71d
to
d35ed3e
Compare
c0f1de9
to
6e659f3
Compare
@CosmicFusion do you have any insight on why the .deb build system removes the executable bits from shared library files? If possible I would like to remove the behavior and inspecting the GH action logs, I believe the cause is from dh_fixperms and I'm not sure if I've configured it correctly in the rules file. Here's the rules file for debian:
|
Confirmed that the shared library files inside the Debian and Ubuntu artifacts have the permission set |
The umu-vendored make target depends on git submodules. Until now, it was disabled with a patch, however that broke in Open-Wine-Components#330. Instead of patching the makefile's `all` target, we can explicitly specify the targets we want to build/install using make flags. This is a temporary workaround until we can figure out how to get submodules working correctly with the flake. The flakeref query `submodules=1` _should_ fix this, but I couldn't get it to work for some reason.
The umu-vendored make target depends on git submodules. Until now, it was disabled with a patch, however that broke in Open-Wine-Components#330. Instead of patching the makefile's `all` target, we can explicitly specify the targets we want to build/install using make flags. This is a temporary workaround until we can figure out how to get submodules working correctly with the flake. The flakeref query `submodules=1` _should_ fix this, but I couldn't get it to work for some reason.
The umu-vendored make target depends on git submodules. Until now, it was disabled with a patch, however that broke in Open-Wine-Components#330. Instead of patching the makefile's `all` target, we can explicitly specify the targets we want to build/install using make flags. This is a temporary workaround until we can figure out how to get submodules working correctly with the flake. The flakeref query `submodules=1` _should_ fix this, but I couldn't get it to work for some reason.
The umu-vendored make target depends on git submodules. Until now, it was disabled with a patch, however that broke in Open-Wine-Components#330. Instead of patching the makefile's `all` target, we can explicitly specify the targets we want to build/install using make flags. This is a temporary workaround until we can figure out how to get submodules working correctly with the flake. The flakeref query `submodules=1` _should_ fix this, but I couldn't get it to work for some reason.
The umu-vendored make target depends on git submodules and is not needed now that we provide pyzstd as a nix package. Until now, it was disabled with a patch, however that broke in Open-Wine-Components#330. Instead of patching the makefile's `all` target, we can explicitly specify the targets we want to build/install using make flags. This is a temporary workaround until the Makefile can automatically disable the target when the dependency is already available. Maybe a make variable?
The umu-vendored make target depends on git submodules and is not needed now that we provide pyzstd as a nix package. Until now, it was disabled with a patch, however that broke in Open-Wine-Components#330. Instead of patching the makefile's `all` target, we can explicitly specify the targets we want to build/install using make flags. This is a temporary workaround until the Makefile can automatically disable the target when the dependency is already available. Maybe a make variable?
The umu-vendored make target depends on git submodules and is not needed now that we provide pyzstd as a nix package. Until now, it was disabled with a patch, however that broke in Open-Wine-Components#330. Instead of patching the makefile's `all` target, we can explicitly specify the targets we want to build/install using make flags. This is a temporary workaround until the Makefile can automatically disable the target when the dependency is already available. Maybe a make variable?
The umu-vendored make target depends on git submodules and is not needed now that we provide pyzstd as a nix package. Until now, it was disabled with a patch, however that broke in Open-Wine-Components#330. Instead of patching the makefile's `all` target, we can explicitly specify the targets we want to build/install using make flags. This is a temporary workaround until the Makefile can automatically disable the target when the dependency is already available. Maybe a make variable? That said, having the install targets listed explicitly allows the `delta` targets to be conditional on `withDeltaUpdates`.
The umu-vendored make target depends on git submodules and is not needed now that we provide pyzstd as a nix package. Until now, it was disabled with a patch, however that broke in Open-Wine-Components#330. Instead of patching the makefile's `all` target, we can explicitly specify the targets we want to build/install using make flags. This is a temporary workaround until the Makefile can automatically disable the target when the dependency is already available. Maybe a make variable?
* Use URL-like flake ref syntax for nixpkgs input This is a purely cosmetic change. * packaging/nix/flake.lock: Update Flake lock file updates: • Updated input 'nixpkgs': 'github:NixOS/nixpkgs/3df3c47c19dc90fec35359e89ffb52b34d2b0e94?narHash=sha256-30sOEZ8CFK2nTTMdkhaNrfVlIi3rWTNV0Z5z%2BNmpFNI%3D' (2025-01-06) → 'github:NixOS/nixpkgs/9a5db3142ce450045840cc8d832b13b8a2018e0c?narHash=sha256-pUvLijVGARw4u793APze3j6mU1Zwdtz7hGkGGkD87qw%3D' (2025-01-29) * Refactor nix flake, based on overriding nixpkgs Now that umu-launcher is being maintained in nixpkgs, it can be used as a starting point for the nix package here. We just need to override a few things, such as the `src`, and handle any changes that have not yet made it into a release build. The opportunity has been taken to clean up that package-args API: - Renamed `truststore` to `withTruststore` with a warning. - `cbor2` wasn't working, warn when it is used. - Added `withDeltaUpdates` Breaking changes: - The umu-launcher package in the overlay is no longer the unwrapped package (previously in `umu-launcher.nix`). - The derivation attrs for various packages are re-written from scratch, likely breaking users' custom overrides. Non-breaking changes: - The umu & umu-run packages have effectively been renamed umu-launcher. - The flake outputs for all systems supported by the nixpkgs package. - The package version now defaults to the flake's git revision. * Warn when nix package version is set unnecessarily The README used to recommend overriding `version = shortRev`, however we now use `shortRev` by default. Notify users of this change by warning when `version` is overridden to the version we would've used anyway. * Add pyzstd to nix package inputs Removed `zstd` from inputs as it is a transitive dependency. * Add urllib3 to nix package inputs * Specify make targets explicitly in nix package The umu-vendored make target depends on git submodules and is not needed now that we provide pyzstd as a nix package. Until now, it was disabled with a patch, however that broke in #330. Instead of patching the makefile's `all` target, we can explicitly specify the targets we want to build/install using make flags. This is a temporary workaround until the Makefile can automatically disable the target when the dependency is already available. Maybe a make variable?
No description provided.