Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

209 reorder codelists #280

Merged
merged 8 commits into from
Jun 19, 2024
Merged

209 reorder codelists #280

merged 8 commits into from
Jun 19, 2024

Conversation

odscjen
Copy link
Collaborator

@odscjen odscjen commented Apr 16, 2024

Related issues

closes #209

Description

Merge checklist

  • Update the changelog (style guide)
  • Run ./manage.py pre-commit to update derivative schema files, reference documentation and examples

If there are changes to network-schema.json, network-package-schema.json, reference/publication_formats/json.md, reference/publication_formats/geojson.md or guidance/publication.md#how-to-publish-large-networks, update the relevant manually authored examples:

  • examples/json/:
    • network-package.json
    • api-response.json
    • multiple-networks.json
    • network-embedded.json
    • network-separate-endpoints.json
    • network-separate-files.json
    • nodes-endpoint.json
    • spans-endpoint.json
  • examples/geojson/:
    • api-response.geojson
    • multiple-networks.geojson

If you used a validation keyword, type or format that is not already used in the schema:

If you added a normative rule that is not encoded in JSON Schema:

If there are changes to examples/geojson/nodes.geojson or examples/geojson/spans.geojson, check and update the data use examples:

  • examples/leaflet/leaflet.ipynb
  • examples/qgis/geojson.qgs

@odscjen
Copy link
Collaborator Author

odscjen commented Apr 16, 2024

reporting broken link

(guidance/publication: line 348) broken https://linux.die.net/man/3/libuuid - 403 Client Error: Forbidden for url: https://linux.die.net/man/3/libuuid

but its not broken, following that url takes you to a working webpage, all be it one with an irritating popup

@odscjen
Copy link
Collaborator Author

odscjen commented Apr 16, 2024

It's also unclear why running manage/py pre-commit changed 2 example files when all this PR has changed is the order of some codelists, not the codes themselves?

@odscjen odscjen marked this pull request as ready for review April 18, 2024 14:04
@odscjen odscjen changed the title codelists: reorder codelists 209 reorder codelists Apr 18, 2024
@odscjen odscjen requested a review from duncandewhurst May 23, 2024 12:55
@odscjen
Copy link
Collaborator Author

odscjen commented May 28, 2024

have created an issue about the pre-commit problem #285

@odscjen
Copy link
Collaborator Author

odscjen commented May 28, 2024

#284 to fix linkcheck error, once that's merged into main, rebase this branch/merge main into this branch

Copy link
Collaborator

@duncandewhurst duncandewhurst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine to merge once my comment is resolved.

codelists/closed/spanStatus.csv Show resolved Hide resolved
@odscjen odscjen requested a review from duncandewhurst June 18, 2024 14:32
@odscjen
Copy link
Collaborator Author

odscjen commented Jun 18, 2024

thanks @duncandewhurst but can't merge until you officially approve :)

@odscjen odscjen merged commit 22807fe into 0.3-dev Jun 19, 2024
10 checks passed
@odscjen odscjen deleted the 209-codelist-reorder branch June 19, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Order codes in codelists
2 participants