schema/network-schema.json: Disallow additional properties in Geometry #274
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issues
Description
This PR relates to an issue that surfaced whilst updating tooling for version 0.3:
Following #262, WKT is used to represent
Geometry
objects in the CSV publication format. WKT does not support additional properties so in order to prevent undefined behaviour and to support roundtripping without data loss, we need to disallow additional properties in theGeometry
object. Certain property names (properties
andfeatures
) were already prohibited, per the GeoJSON specification. Given that there are not yet any implementations and given that we've heard no demand for additional properties withinGeometry
objects, I think this change is fine to make.Merge checklist
./manage.py pre-commit
to update derivative schema files, reference documentation and examplesIf you used a validation keyword, type or format that is not already used in the schema:
Add a field that fails validation against the new keyword, type or format to(existing file is sufficient)network-package-invalid.json
.