Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/primer/openfibredatastandard.md: Emphasise categories of data #264

Merged
merged 4 commits into from
May 17, 2023

Conversation

duncandewhurst
Copy link
Collaborator

@duncandewhurst duncandewhurst commented May 3, 2023

Related issues

Description

Merge checklist

  • Update the changelog (style guide)
  • Run ./manage.py pre-commit to update derivative schema files, reference documentation and examples

If there are changes to network-schema.json, network-package-schema.json, reference/publication_formats/json.md, reference/publication_formats/geojson.md or guidance/publication.md#how-to-publish-large-networks, update the relevant manually authored examples:

  • examples/json/:
    • network-package.json
    • api-response.json
    • multiple-networks.json
    • network-embedded.json
    • network-separate-endpoints.json
    • network-separate-files.json
    • nodes-endpoint.json
    • spans-endpoint.json
  • examples/geojson/:
    • api-response.geojson
    • multiple-networks.geojson

If you used a validation keyword, type or format that is not already used in the schema:

If you added a normative rule that is not encoded in JSON Schema:

If there are changes to examples/geojson/nodes.geojson or examples/geojson/spans.geojson, check and update the data use examples:

  • examples/leaflet/leaflet.ipynb
  • examples/qgis/geojson.qgs

@duncandewhurst duncandewhurst marked this pull request as ready for review May 3, 2023 22:53
@duncandewhurst
Copy link
Collaborator Author

@stevesong please could you check that you're happy with the changes in this PR? You can view a diff or preview the built documentation.

@duncandewhurst
Copy link
Collaborator Author

@stevesong please could you check that you're happy with the changes in this PR? You can view a diff or preview the built documentation.

@stevesong just checking that you didn't miss this request!

@duncandewhurst duncandewhurst requested a review from rhiaro May 9, 2023 23:34
@duncandewhurst duncandewhurst merged commit ba65df9 into 0.3-dev May 17, 2023
@duncandewhurst duncandewhurst deleted the 235-update-primer branch May 17, 2023 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Primer: Highlight the different categories of data covered in the schema
2 participants