Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs/guidance/publication.md: Add link to CoVE #196

Merged
merged 3 commits into from
Nov 22, 2022

Conversation

duncandewhurst
Copy link
Collaborator

@duncandewhurst duncandewhurst commented Nov 22, 2022

Related issues
Add links to related issues here. Use keywords if you want an issue to be automatically closed when the PR is merged.

Description
If the changes in the PR are not sufficiently explained by the related issues and commit messages, add a description here

Merge checklist

  • If there are changes to network-schema.json, network-package-schema.json, reference/publication_formats/json.md, reference/publication_formats/geojson.md or guidance/publication.md#how-to-publish-large-networks, update the relevant manually authored examples:
    • examples/json/:
      • network-package.json
      • api-response.json
      • multiple-networks.json
      • network-embedded.json
      • network-separate-endpoints.json
      • network-separate-files.json
      • nodes-endpoint.json
      • spans-endpoint.json
    • examples/geojson/:
      • api-response.geojson
      • multiple-networks.geojson
  • Run ./manage.py pre-commit to update derivative schema files, reference documentation and examples
  • If you used a validation keyword, type or format that is not already used in the schema:
  • If you added a normative rule that is not encoded in JSON Schema:
  • If there are changes to examples/geojson/nodes.geojson or examples/geojson/spans.geojson, check and update the data use examples:
    • examples/leaflet/leaflet.ipynb
    • examples/qgis/geojson.qgs
  • Update the changelog (style guide)

@duncandewhurst duncandewhurst requested a review from lgs85 November 22, 2022 03:36
@duncandewhurst duncandewhurst marked this pull request as ready for review November 22, 2022 03:36
lgs85
lgs85 previously approved these changes Nov 22, 2022
@lgs85 lgs85 merged commit a4e0aad into 0.1-dev Nov 22, 2022
@lgs85 lgs85 deleted the 194-data-review-tool-admonition branch November 22, 2022 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data review tool admonition
2 participants