Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a link to CoVE in the sidebar #198

Closed
duncandewhurst opened this issue Nov 22, 2022 · 5 comments · Fixed by #273
Closed

Add a link to CoVE in the sidebar #198

duncandewhurst opened this issue Nov 22, 2022 · 5 comments · Fixed by #273
Assignees
@Bjwebb
Labels
Build This issue relates to the build process Non-normative documentation
Milestone
Iterative improve...

Comments

@duncandewhurst
Copy link
Collaborator

Once #196 is merged, there will be a link to CoVE in the publication guidance. We should add a link to the sidebar so that it is more discoverable.

We can likely use a similar to approach OCDS's layout.html.
@duncandewhurst duncandewhurst added Non-normative documentation Build This issue relates to the build process labels Nov 22, 2022
@duncandewhurst duncandewhurst added this to the Iterative improvements milestone Jan 9, 2023
@duncandewhurst
Copy link
Collaborator Author

The link can appear after the TOC in the sidebar. I think that the text should be 'Convert, Validate and Explore your data'.

@Bjwebb Bjwebb self-assigned this Jun 13, 2023
@Bjwebb
Copy link
Contributor

Bjwebb commented Jun 13, 2023

The easiest thing to do is to add it without extra spacing: https://open-fibre-data-standard.readthedocs.io/en/nav-link-cove/

Or, do you want extra spacing like OCDS? https://standard.open-contracting.org/latest/en/

@duncandewhurst
Copy link
Collaborator Author

Without extra spacing is fine.

Looking at the preview, I would like to make a few tweaks:

  1. I think the text should be 'Convert, Validate and Expore Tool' to better signal that the link leads to a tool, rather than a documentation page.
  2. The link should open in a new tab/window.
  3. To distinguish it from the other menu items, would it be possible to add an external link icon like the one below?

image

Thanks!

Bjwebb added a commit that referenced this issue Jun 15, 2023
@Bjwebb
Add CoVE link to the navigation
2c51b86 
#198
@Bjwebb
Copy link
Contributor

Bjwebb commented Jun 15, 2023

I've made all those changes, how does this look: https://open-fibre-data-standard.readthedocs.io/en/198-nav-link-cove/

@duncandewhurst
Copy link
Collaborator Author

Perfect! Thank you :-)

@Bjwebb Bjwebb mentioned this issue Jun 20, 2023
Merged
2 tasks
Bjwebb added a commit that referenced this issue Jun 20, 2023
@Bjwebb
Add CoVE link to the navigation
e1285d5 
#198
Bjwebb added a commit that referenced this issue Jun 21, 2023
@Bjwebb
Add CoVE link to the navigation
874c31b 
#198
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Bjwebb Bjwebb

Labels
Build This issue relates to the build process Non-normative documentation
Projects
None yet
Milestone
Iterative improvements
Development

Successfully merging a pull request may close this issue.

Add CoVE link to the navigation Open-Telecoms-Data/open-fibre-data-standard
2 participants
@Bjwebb @duncandewhurst