Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

work #50

Merged
4 commits merged into from
Nov 18, 2022
Merged

work #50

4 commits merged into from
Nov 18, 2022

Conversation

ghost
Copy link

@ghost ghost commented Nov 17, 2022

No description provided.

@ghost ghost requested a review from Lathrisk November 17, 2022 16:35
@ghost ghost self-assigned this Nov 17, 2022
@ghost ghost changed the title jsonschema_validation: Columns and fix wrong types work Nov 17, 2022
@ghost ghost force-pushed the 2022-11-17 branch from f67c3c5 to 3c1885d Compare November 17, 2022 16:56
@ghost ghost force-pushed the 2022-11-17 branch 2 times, most recently from 2385e54 to 4e71f02 Compare November 18, 2022 09:04
Copy link
Contributor

@Lathrisk Lathrisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, besides one non-blocking comment

@ghost ghost merged commit 3c491e6 into ng Nov 18, 2022
@ghost ghost deleted the 2022-11-17 branch November 18, 2022 11:46
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants