Skip to content

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jan 7, 2026

Bumps preact from 10.28.1 to 10.28.2.

Release notes

Sourced from preact's releases.

10.28.2

Fixes

  • Enforce strict equality for VNode object constructors
Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
    You can disable automated security fix PRs for this repo from the Security Alerts page.

@dependabot dependabot bot added dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code labels Jan 7, 2026
@JSv4
Copy link
Collaborator

JSv4 commented Jan 8, 2026

@dependabot rebase

Bumps [preact](https://github.com/preactjs/preact) from 10.28.1 to 10.28.2.
- [Release notes](https://github.com/preactjs/preact/releases)
- [Commits](preactjs/preact@10.28.1...10.28.2)

---
updated-dependencies:
- dependency-name: preact
  dependency-version: 10.28.2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot bot force-pushed the dependabot/npm_and_yarn/frontend/preact-10.28.2 branch from 133a753 to 1ffff08 Compare January 8, 2026 13:42
@claude
Copy link

claude bot commented Jan 8, 2026

PR Review: Preact 10.28.1 → 10.28.2 Dependency Update

Summary

This is a Dependabot-generated PR that updates Preact from 10.28.1 to 10.28.2 in the frontend dependencies. The update is a patch version bump that addresses a security-related fix.

Code Quality ✅

  • Clean dependency update: Only modifies yarn.lock as expected
  • Follows semver: Patch version indicates backwards-compatible bug fix
  • No breaking changes: Safe to merge

Security Analysis 🔒

The 10.28.2 release includes an important fix:

  • "Enforce strict equality for VNode object constructors" (PR #4985)
  • This change strengthens type checking to prevent potential object constructor confusion attacks
  • While not classified as a critical CVE, it's a security-hardening measure that should be applied

Impact Assessment 📊

Preact usage in codebase:

  • Preact is a transitive dependency via posthog-js@^1.312.0 (PostHog analytics)
  • Not directly imported or used in application code
  • Impact is limited to PostHog's internal rendering

Risk level:Low

  • No application code changes required
  • PostHog uses Preact for lightweight UI components
  • Patch version guarantees compatibility

Testing Considerations ✅

Based on CLAUDE.md testing guidelines:

Recommended verification:

# Frontend type checking
cd frontend && yarn build

# Unit tests (if PostHog integration is tested)
yarn test:unit

# Component tests
yarn test:ct --reporter=list

Why minimal testing is acceptable:

  1. Transitive dependency with no direct usage
  2. Patch version with strict equality fix (unlikely to break existing code)
  3. PostHog is an analytics library with isolated rendering

Performance Considerations ✅

  • No performance impact expected
  • Strict equality checks may provide marginal performance improvement
  • Bundle size unchanged (patch-level update)

Recommendations

Approve and merge - This is a safe, security-improving update

Optional follow-up:

  • Monitor PostHog analytics after deployment to ensure no regressions
  • Consider enabling Dependabot auto-merge for patch-level updates to expedite security fixes

Compliance with CLAUDE.md

  • ✅ No manual credit to Claude required (Dependabot PR)
  • ✅ No CHANGELOG.md update needed (dependency update, not feature/fix)
  • ✅ Pre-commit hooks will run automatically
  • ✅ Follows trunk-based development (merge to main)

Verdict: 🟢 LGTM - Safe to merge after CI passes

@JSv4 JSv4 merged commit a2b8ef5 into main Jan 8, 2026
9 checks passed
@JSv4 JSv4 deleted the dependabot/npm_and_yarn/frontend/preact-10.28.2 branch January 8, 2026 14:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update Javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants