-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clarify: Send token to discovery endpoints #416 #417
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In general: clarification seem bit oriented to web editor or comparable interactive interfaces, where you for example a collection listing widget that should update once user is logged in.
In case of python or R client, the recommendation makes less sense as it's the responsibility of the user to re-request collections listings and update all relevant variables they created. This is out of reach nor the responsibility of the client libraries I think.
For example: I'm not sure what makes sense to do in python client to cover this clarification at the moment.
@soxofaan Sure, the primary use case that comes to mind is the Web Editor, but it's not the only use case. It depends on whether you are storing e.g. a collection or processes cache in the client, which I think is at least true in the JS client and R client for processes. So once logged in these caches would need to be cleared/updated.
Not sure whether it's implemented yet, but you'd need to send the Bearer token to the discovery endpoints if available. I'm not sure all (programming) clients do that yet. If Python does it, then there's probably nothing to do, indeed. |
Co-authored-by: Stefaan Lippens <[email protected]>
In the Python client there is (currently) caching of
only |
Yes.
I guess that meant "Should be easy"? Is the Python client sending the Bearer token to Collections etc if available? |
indeed :)
python client always sends bearer if available (even if not necessary) |
See issue #416 and discussions around private collections in openEO Platform.
This is not really a new thing, but more a clarification for clients that this behavior can be useful.