Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide types for external use #141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ElwynVdb
Copy link

@ElwynVdb ElwynVdb commented Apr 25, 2024

Overview

This pull request contains the exporting of the type definitions within the index.ts file.

Benefits

  • Developers can now import types directly, avoiding the use of complex and less intuitive syntax to access type definitions.
  • Easier access to type definitions encourages proper typing, which can lead to more maintainable and less error-prone code.

Related open issues

@veewee
Copy link

veewee commented May 3, 2024

@jkasten2 / @rgomezp

Not having decent type reusability in typescript is a bit annyoing: If we want to accept e.g. an IOSNotification object in one of our functions - there is no way to type it with typescript other than including the type directly in the project. Making it vulnerable for future API updates where the type in our project won't match the one-signal type anymore.

Would this be something you are interested in merging?
Let us know if we can do anything to help you getting this into this repository.

Copy link

@adwher adwher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants