Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sample code #224

Merged
merged 5 commits into from
Mar 25, 2024
Merged

Update sample code #224

merged 5 commits into from
Mar 25, 2024

Conversation

opmat
Copy link
Contributor

@opmat opmat commented Feb 1, 2024 •
edited
Loading

Description

One Line Summary

Update the provided sample code in examples/RNOneSignalExpoExample to reflect code changes in version 2.0.2 of the plugin.

Details

Motivation

The code is made to guide new OneSignal users on the use of the plugin using the updated version as the sample was last updated March 2023.

Scope

Just the sample code is changed and does not affect the workings of the actual plugin

Testing

Manual testing

The sample code was tested using Android Emulator (Pixel 5 with API 33) and iOS simulator (iPhone 15 Pro Max with iOS17).

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have personally tested this on my device, or explained why that is not possible
  • I have tested this on the latest version of the plugin
  • I have tested this on both Android and iOS, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

opmat added 5 commits February 1, 2024 19:07
@opmat
Update tsconfig.json
99ae88e 
add  "jsx": "react",
@opmat
Update package.json
8330df4 
- Bump version to 1.0.1
- Update dependencies
  - Bump react and react-dom from version 17.0.2 to 18.2.0
  - Bump react-native from version 0.68.2 to 0.72.6
  - Bump react-native-onesignal from version 4.4.1 to 5.0.4
  - Bump onesignal-expo-plugin from version 1.3.2 to 2.0.2
  - Bump expo from version 45.0.0 to 49.0.15 (45.0.0 of deprecated)
  - and so on
@opmat
Update eas.json
b36e280 
- Bump supported eas-cli version from 0.48.2 to minimum 5.6.0
@opmat
Update app.json
19eb36e 
- Bump version to 1.0.1
@opmat
Update App.tsx
5a81776 
Update the code to reflect changes in plugin version 2.0.2
@opmat
Copy link
Contributor Author

opmat commented Mar 22, 2024

Hi @rgomezp
Thanks for approving the pull request.
Just wondering when it will be merged.
Thank you.

@rgomezp rgomezp merged commit d7d3091 into OneSignal:main Mar 25, 2024
@opmat opmat deleted the update-sample-code branch March 27, 2024 07:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rgomezp rgomezp rgomezp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@opmat @rgomezp