Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md for clarity #157

Merged
merged 1 commit into from
Jan 13, 2023
Merged

Update README.md for clarity #157

merged 1 commit into from
Jan 13, 2023

Conversation

rgomezp
Copy link
Contributor

@rgomezp rgomezp commented Jan 12, 2023

Description

One Line Summary

Updates the README to add more clarity on certain sections that may cause confusion.

Details

Motivation

We were not providing examples on the different iOS-specific version numbers. For someone not deeply involved in iOS world, this may be confusing.

Also, some folks in the past did not know they need to install both this plugin and the react-native-onesignal package.

@rgomezp rgomezp requested a review from brismithers January 12, 2023 20:11
@rgomezp rgomezp force-pushed the update-readme branch 2 times, most recently from de1286c to c3348ce Compare January 12, 2023 20:16
@rgomezp rgomezp merged commit 7de7cef into main Jan 13, 2023
@rgomezp rgomezp deleted the update-readme branch January 13, 2023 19:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants