Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[JWT] Handle when jwt_required is not returned in remote params #1491

Conversation

nan-li
Copy link
Contributor

@nan-li nan-li commented Oct 5, 2024

Description

One Line Summary

When remote params did not return IOS_JWT_REQUIRED, assume off, unless this value has already been set.

Details

  • remote params may not return the property IOS_JWT_REQUIRED.
  • It is likely this feature is not enabled for the app, so we will assume it is off.
  • However, don't overwrite the value if this has already been set.

Motivation

Identity Verification support should work with existing apps with no change.

Scope

Reading remote params and assuming a value

Testing

Unit testing

None

Manual testing

iOS 15 simulator on 17.2
Tested production and faking it receiving jwt_required and not receiving it.

Affected code checklist

  • Notifications
    • Display
    • Open
    • Push Processing
    • Confirm Deliveries
  • Outcomes
  • Sessions
  • In-App Messaging
  • REST API requests
  • Public API changes

Checklist

Overview

  • I have filled out all REQUIRED sections above
  • PR does one thing
    • If it is hard to explain how any codes changes are related to each other then it most likely needs to be more than one PR
  • Any Public API changes are explained in the PR details and conform to existing APIs

Testing

  • I have included test coverage for these changes, or explained why they are not needed
  • All automated tests pass, or I explained why that is not possible
  • I have personally tested this on my device, or explained why that is not possible

Final pass

  • Code is as readable as possible.
    • Simplify with less code, followed by splitting up code into well named functions and variables, followed by adding comments to the code.
  • I have reviewed this PR myself, ensuring it meets each checklist item
    • WIP (Work In Progress) is ok, but explain what is still in progress and what you would like feedback on. Start the PR title with "WIP" to indicate this.

This change is Reviewable

@nan-li nan-li requested a review from emawby October 5, 2024 00:33
@nan-li nan-li merged commit facb589 into identity_verification_app_startup Oct 5, 2024
2 checks passed
@nan-li nan-li deleted the identity_verification_works_with_prod branch October 5, 2024 00:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants