Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup generator package #71

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Cleanup generator package #71

merged 5 commits into from
Aug 20, 2024

Conversation

theEvilReaper
Copy link

Proposed changes

Due to the latest pull request, some changes in the generator package were overwritten by code from the main repository. To enhance code structure and maintainability, this pull request improves the use of strings, functions, and other elements

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

@theEvilReaper theEvilReaper added the documentation Improvements or additions to documentation label Aug 19, 2024
@theEvilReaper theEvilReaper requested a review from a team as a code owner August 19, 2024 10:49
Copy link

sonarcloud bot commented Aug 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@theEvilReaper theEvilReaper merged commit 9179372 into master Aug 20, 2024
5 of 6 checks passed
@theEvilReaper theEvilReaper deleted the feature/generatorCleanup branch August 20, 2024 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation Feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants