Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Testing #65

Merged
merged 9 commits into from
Aug 19, 2024
Merged

Improved Testing #65

merged 9 commits into from
Aug 19, 2024

Conversation

TheMeinerLP
Copy link
Collaborator

Proposed changes

This PR improves testing for developers and internally. To bring us closer to JUnit5.
The version has been upgraded to 1.5.0.
All tests have been adapted to the new environment. And old things have been deprecated and marked with a replacement

Closes #62

Types of changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of
them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.

  • I have read the CONTRIBUTING.md
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...

@TheMeinerLP TheMeinerLP requested a review from a team as a code owner June 16, 2024 15:01
Copy link

@theEvilReaper theEvilReaper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

# Conflicts:
#	build.gradle.kts
#	src/test/java/net/minestom/server/collision/EntityBlockPhysicsIntegrationTest.java
#	src/test/java/net/minestom/server/entity/EntityMetaIntegrationTest.java
#	src/test/java/net/minestom/server/entity/EntityViewDirectionIntegrationTest.java
#	src/test/java/net/minestom/server/entity/player/PlayerBlockPlacementIntegrationTest.java
#	src/test/java/net/minestom/server/instance/BiomeIntegrationTest.java
#	src/test/java/net/minestom/server/instance/GeneratorIntegrationTest.java
#	src/test/java/net/minestom/server/instance/InstanceBlockIntegrationTest.java
#	src/test/java/net/minestom/server/instance/InstanceBlockPacketIntegrationTest.java
#	src/test/java/net/minestom/server/instance/WorldBorderIntegrationTest.java
#	src/test/java/net/minestom/server/instance/anvil/AnvilLoaderIntegrationTest.java
#	src/test/java/net/minestom/server/instance/generator/GeneratorForkConsumerIntegrationTest.java
#	src/test/java/net/minestom/server/instance/light/LightParityIntegrationTest.java
#	src/test/java/net/minestom/server/inventory/InventoryIntegrationTest.java
#	src/test/java/net/minestom/server/item/ItemAttributeTest.java
Copy link

sonarcloud bot commented Aug 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
67.7% Coverage on New Code (required ≥ 80%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

1 similar comment
Copy link

sonarcloud bot commented Aug 19, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
67.7% Coverage on New Code (required ≥ 80%)
E Reliability Rating on New Code (required ≥ A)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@TheMeinerLP TheMeinerLP merged commit fd40028 into master Aug 19, 2024
5 of 6 checks passed
@TheMeinerLP TheMeinerLP deleted the feature/improved_testing branch August 19, 2024 08:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change or revise the testing framework
2 participants