Revise Game tag System #40
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codestech1
suggested changes
May 27, 2024
src/main/java/net/minestom/server/network/packet/server/common/TagsPacket.java
Show resolved
Hide resolved
|
Codestech1
suggested changes
May 29, 2024
Comment on lines
+30
to
+31
| tagsMap.put(NamespaceID.from(EntityTag.IDENTIFIER), new ArrayList<>(EntityTag.values())); | ||
| // tagsMap.put(NamespaceID.from(GameEventTag.IDENTIFIER), new ArrayList<>(GameEventTag.values())); |
There was a problem hiding this comment.
While Minecraft protocol allows us to register a game event tag, we need to implement it.
There was a problem hiding this comment.
But we don't have a registry currently. Can you send a proof ?
There was a problem hiding this comment.
But we don't have a registry currently. Can you send a proof ?
Sure,
https://wiki.vg/Protocol#Update_Tags_.28configuration.29
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #39
This PR aims to replace the old game tag system from Minestom. The old system did not use generation, but a hybrid. During testing it was noticed that this causes errors.
By adding a generic tag structure to read all values from the files, we make it easier to generate the tags
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...