[Chore] Replace enum with code generator for fluids #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # code-generators/src/main/java/net/minestom/codegen/Generators.java
TheMeinerLP
changed the title
theEvilReaper
requested changes
May 25, 2024
|
TheMeinerLP
added a commit
that referenced
this pull request
May 26, 2024
* Move Fluids to CodeGenerator * [Chore] Replace enum with registry * Refactor: Move 'Fluids' interface from FluidImpl implements to Fluid extends --------- Co-authored-by: OneLiteFeather <[email protected]>
theEvilReaper
added a commit
that referenced
this pull request
May 26, 2024
* [Chore] Replace enum with registry system for feature flags * Remove wildcard import * Create CNAME * Bump snapshot version (#31) * [Bugfix] Fix failing tests * Update build.gradle.kts * [Chore] Replace enum with code generator for fluids (#27) * Move Fluids to CodeGenerator * [Chore] Replace enum with registry * Refactor: Move 'Fluids' interface from FluidImpl implements to Fluid extends --------- Co-authored-by: OneLiteFeather <[email protected]> * [Chore] Replace enum with registry system for feature flags * Remove wildcard import --------- Co-authored-by: theEvilReaper <[email protected]> Co-authored-by: OneLiteFeather <[email protected]>
theEvilReaper
pushed a commit
that referenced
this pull request
Jun 25, 2024
* Move Fluids to CodeGenerator * [Chore] Replace enum with registry * Refactor: Move 'Fluids' interface from FluidImpl implements to Fluid extends --------- Co-authored-by: OneLiteFeather <[email protected]>
theEvilReaper
added a commit
that referenced
this pull request
Jun 25, 2024
* [Chore] Replace enum with registry system for feature flags * Remove wildcard import * Create CNAME * Bump snapshot version (#31) * [Bugfix] Fix failing tests * Update build.gradle.kts * [Chore] Replace enum with code generator for fluids (#27) * Move Fluids to CodeGenerator * [Chore] Replace enum with registry * Refactor: Move 'Fluids' interface from FluidImpl implements to Fluid extends --------- Co-authored-by: OneLiteFeather <[email protected]> * [Chore] Replace enum with registry system for feature flags * Remove wildcard import --------- Co-authored-by: theEvilReaper <[email protected]> Co-authored-by: OneLiteFeather <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
Fixes #12
This pr points to replace the static enum with dynamic generic generated interfaces system like everything else in minestom.
Types of changes
What types of changes does your code introduce to this project?
Put an
xin the boxes that applyChecklist
Put an
xin the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any ofthem, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before
merging your code.
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you
did and what alternatives you considered, etc...